CPP: Deal with two very similar Japanese era queries#1847
Merged
Conversation
…f deprecated queries is helpful.
jbj
reviewed
Aug 30, 2019
Contributor
|
qhelp LGTM |
rdmarsh2
reviewed
Aug 30, 2019
| <overview> | ||
| <p> | ||
| When eras change, date and time conversions that rely on a hard-coded era start date need to be reviewed. Conversions relying on Japanese dates in the current era can produce an ambiguous date. | ||
| The values for the current Japanese era dates should be read from a source that will be updated, such as the Windows registry. |
Contributor
There was a problem hiding this comment.
We should add some guidance on handling this on Linux and MacOS systems as well.
Contributor
Author
There was a problem hiding this comment.
Do you know what the right guidance might be?
|
|
||
| <references> | ||
| <li> | ||
| <a href="https://blogs.msdn.microsoft.com/shawnste/2018/04/12/the-japanese-calendars-y2k-moment/">The Japanese Calendar's Y2K Moment</a>. |
Contributor
There was a problem hiding this comment.
And some Linux and MacOS references as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1838, this PR deals with two user contributed queries that have an identical name. Following the rename, I decided to combine the two queries into one since there is really no reason a user would want to use one query but not the other, or distinguish between their results. The resulting query is also in a more logical existing directory.